mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-01-20 02:50:46 -06:00
Code Issues Packages Projects Releases Wiki Activity

ExtendedTableWidget: Fix jumpy scrolling

Browse Source 
Fix wrong scrolling behaviour that ocurred when going to the very bottom
of the table and scrolling up slowly.
This commit is contained in:
Martin Kleusberg
2013-04-17 20:26:55 +02:00
parent c0441dcd97
commit e057f97773
2 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/ExtendedTableWidget.cpp
View File

@@ -69,7 +69,7 @@ void ExtendedTableWidget::updateGeometries()
// If so and if it is a SqliteTableModel and if the parent implementation of this method decided that a scrollbar is needed, update its maximum value
SqliteTableModel* m = qobject_cast<SqliteTableModel*>(model());
if(m && verticalScrollBar()->maximum())
verticalScrollBar()->setMaximum(m->totalRowCount());
verticalScrollBar()->setMaximum(m->totalRowCount() - numVisibleRows() + 1);
}
}
@@ -79,12 +79,17 @@ void ExtendedTableWidget::vscrollbarChanged(int value)
if(!model())
return;
// How many rows are visible right now?
int row_top = rowAt(0) == -1 ? 0 : rowAt(0);
int row_bottom = rowAt(height()) == -1 ? model()->rowCount() : rowAt(height());
int num_visible_rows = row_bottom - row_top;
// Fetch more data from the DB if necessary
if((value + num_visible_rows) >= model()->rowCount() && model()->canFetchMore(QModelIndex()))
if((value + numVisibleRows()) >= model()->rowCount() && model()->canFetchMore(QModelIndex()))
model()->fetchMore(QModelIndex());
}
int ExtendedTableWidget::numVisibleRows()
{
// Get the row numbers of the rows currently visible at the top and the bottom of the widget
int row_top = rowAt(0) == -1 ? 0 : rowAt(0);
int row_bottom = rowAt(height()) == -1 ? model()->rowCount() : rowAt(height());
// Calculate the number of visible rows
return row_bottom - row_top;
}

1
src/ExtendedTableWidget.h
View File

@@ -12,6 +12,7 @@ public:
private:
void copy();
int numVisibleRows();
private slots:
void vscrollbarChanged(int value);