mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-01-19 18:40:13 -06:00
Code Issues Packages Projects Releases Wiki Activity

Better identifier quoting

Browse Source 
This commit fixes the SQL export which did not quote the field names in
the INSERT statements.

This also simplifies the code for escaping SQL identifiers.
This commit is contained in:
Martin Kleusberg
2018-11-16 11:05:13 +01:00
parent 9e36f21112
commit ef7492adfb
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/sqlitedb.cpp
View File

@@ -734,7 +734,7 @@ bool DBBrowserDB::dump(const QString& filePath,
{
stream << "INSERT INTO " << sqlb::escapeIdentifier(it->name());
if (insertColNames)
stream << " (" << cols.join(",") << ")";
stream << " (" << sqlb::escapeIdentifier(cols).join(",") << ")";
stream << " VALUES (";
}
else
@@ -1139,9 +1139,7 @@ QString DBBrowserDB::emptyInsertStmt(const QString& schemaName, const sqlb::Tabl
stmt.append(" DEFAULT VALUES;");
} else {
stmt.append("(");
for(const QString& f : fields)
stmt.append(sqlb::escapeIdentifier(f) + ",");
stmt.chop(1);
stmt.append(sqlb::escapeIdentifier(fields).join(","));
stmt.append(") VALUES (");
stmt.append(vals.join(","));
stmt.append(");");