mirror/ternfs-XTXMarkets
1
0
Fork 0
mirror of https://github.com/XTXMarkets/ternfs.git synced 2026-05-06 20:31:17 -05:00
Code Issues Packages Projects Releases Wiki Activity

Do not trust RocksDB upper bound

Browse Source
This commit is contained in:
Francesco Mazzoli
2026-02-26 22:58:03 +00:00
parent 66896c3dea
commit c01c15efd1
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cpp/cdc/CDCDB.cpp
+13 -5
View File
@@ -1698,14 +1698,22 @@ struct CDCDBImpl {
sentinelK().setDirId(dirId);
sentinelK().setSentinel();
it->Next();
bool removeSentinel = true;
if (it->Valid()) { // there's something, set the sentinel
auto nextK = ExternalValue<DirsToTxnsKey>::FromSlice(it->key());
auto sentinelV = CDCTxnIdValue::Static(nextK().txnId());
LOG_DEBUG(_env, "selected %s as next in line after finishing %s", nextK().txnId(), txnId);
mightBeReady.emplace_back(nextK().txnId());
ROCKS_DB_CHECKED(dbTxn.Put(_dirsToTxnsCf, sentinelK.toSlice(), sentinelV.toSlice()));
} else { // we were the last ones here, remove sentinel
if (nextK().dirId() == dirId) {
removeSentinel = false;
auto sentinelV = CDCTxnIdValue::Static(nextK().txnId());
LOG_DEBUG(_env, "selected %s as next in line after finishing %s", nextK().txnId(), txnId);
mightBeReady.emplace_back(nextK().txnId());
ROCKS_DB_CHECKED(dbTxn.Put(_dirsToTxnsCf, sentinelK.toSlice(), sentinelV.toSlice()));
} else {
RAISE_ALERT_APP_TYPE(_env, XmonAppType::DAYTIME, "Unexpectedly stepped from %s to %s, is RocksDB not respecting our upper bound?", dirId, nextK().dirId());
}
} else {
ROCKS_DB_CHECKED(it->status());
}
if (removeSentinel) { // we were the last ones here, remove sentinel
ROCKS_DB_CHECKED(dbTxn.Delete(_dirsToTxnsCf, sentinelK.toSlice()));
}
}