fix(build-wc): honor custom component name for single file wc builds (#1182)

Fixes issue that prevented single entry wc builds from honoring the `--name` argument.

fix #1146
This commit is contained in:
Derek Henscheid
2018-04-27 16:48:32 -05:00
committed by Evan You
parent 81d29ab30b
commit 2b236e0475
2 changed files with 31 additions and 14 deletions

View File

@@ -18,6 +18,7 @@ module.exports = (api, { target, entry, name }) => {
// generate dynamic entry based on glob files
const resolvedFiles = require('globby').sync([entry], { cwd: api.resolve('.') })
if (!resolvedFiles.length) {
abort(`entry pattern "${entry}" did not match any files.`)
}
@@ -38,7 +39,7 @@ module.exports = (api, { target, entry, name }) => {
}
}
const dynamicEntry = resolveEntry(prefix, resolvedFiles, isAsync)
const dynamicEntry = resolveEntry(prefix, libName, resolvedFiles, isAsync)
function genConfig (minify, genHTML) {
const config = api.resolveChainableWebpackConfig()
@@ -85,9 +86,12 @@ module.exports = (api, { target, entry, name }) => {
inject: false,
filename: 'demo.html',
libName,
components: resolvedFiles.map(file => {
return fileToComponentName(prefix, file).kebabName
})
components:
prefix === ''
? [libName]
: resolvedFiles.map(file => {
return fileToComponentName(prefix, file).kebabName
})
}])
}

View File

@@ -11,6 +11,22 @@ const hyphenate = str => {
return str.replace(hyphenateRE, '-$1').toLowerCase()
}
/**
* Creates the script to add the component to the custom elements
* @param {string} prefix The prefix for the component library
* @param {string} component The component name for single entry builds, component file for multi-entry builds
* @param {string} file The file for the component
* @param {boolean} async Whether to load component async or not
*/
const createElement = (prefix, component, file, async) => {
const { camelName, kebabName } = exports.fileToComponentName(prefix, component)
return async
? `window.customElements.define('${kebabName}', wrap(Vue, () => import('~root/${file}')))\n`
: `import ${camelName} from '~root/${file}'\n` +
`window.customElements.define('${kebabName}', wrap(Vue, ${camelName}))\n`
}
exports.fileToComponentName = (prefix, file) => {
const basename = path.basename(file).replace(/\.(jsx?|vue)$/, '')
const camelName = camelize(basename)
@@ -22,8 +38,13 @@ exports.fileToComponentName = (prefix, file) => {
}
}
exports.resolveEntry = (prefix, files, async) => {
exports.resolveEntry = (prefix, libName, files, async) => {
const filePath = path.resolve(__dirname, 'entry-wc.js')
const elements =
prefix === ''
? [createElement('', libName, files[0])]
: files.map(file => createElement(prefix, file, file, async)).join('\n')
const content = `
import Vue from 'vue'
import wrap from '@vue/web-component-wrapper'
@@ -40,15 +61,7 @@ import 'vue-loader/lib/runtime/component-normalizer'
}
})()
${files.map(file => {
const { camelName, kebabName } = exports.fileToComponentName(prefix, file)
return async
? `window.customElements.define('${kebabName}', wrap(Vue, () => import('~root/${file}')))\n`
: (
`import ${camelName} from '~root/${file}'\n` +
`window.customElements.define('${kebabName}', wrap(Vue, ${camelName}))\n`
)
}).join('\n')}`.trim()
${elements}`.trim()
fs.writeFileSync(filePath, content)
return filePath
}