mirror/vue-cli
1
0
Fork 0
mirror of https://github.com/vuejs/vue-cli.git synced 2026-04-26 14:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: changed var async to isAsync (#4909)

Browse Source 
`async` is a javascript keyword, so I suggest this variable name will be less prone to error and confusing.
This commit is contained in:
Kumar Gaurav
2019-12-06 08:27:43 +05:30
committed by Haoqun Jiang
parent 6c2496418e
commit aeddc6f2c9
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/@vue/cli-service/lib/commands/build/resolveWcEntry.js
+5 -5
View File
@@ -16,12 +16,12 @@ const hyphenate = str => {
* @param {string} prefix The prefix for the component library
* @param {string} component The component name for single entry builds, component file for multi-entry builds
* @param {string} file The file for the component
* @param {boolean} async Whether to load component async or not
* @param {boolean} isAsync Whether to load component async or not
*/
const createElement = (prefix, component, file, async) => {
const createElement = (prefix, component, file, isAsync) => {
const { camelName, kebabName } = exports.fileToComponentName(prefix, component)
return async
return isAsync
? `window.customElements.define('${kebabName}', wrap(Vue, () => import('~root/${file}?shadow')))\n`
: `import ${camelName} from '~root/${file}?shadow'\n` +
`window.customElements.define('${kebabName}', wrap(Vue, ${camelName}))\n`
@@ -38,12 +38,12 @@ exports.fileToComponentName = (prefix, file) => {
}
}
exports.resolveEntry = (prefix, libName, files, async) => {
exports.resolveEntry = (prefix, libName, files, isAsync) => {
const filePath = path.resolve(__dirname, 'entry-wc.js')
const elements =
prefix === ''
? [createElement('', libName, files[0])]
: files.map(file => createElement(prefix, file, file, async)).join('\n')
: files.map(file => createElement(prefix, file, file, isAsync)).join('\n')
const content = `
import './setPublicPath'