mirror/vue-cli
1
0
Fork 0
mirror of https://github.com/vuejs/vue-cli.git synced 2026-01-15 11:50:19 -06:00
Code Issues Packages Projects Releases Wiki Activity

feat(babel-preset): set target to node whenever NODE_ENV === 'test' (#4663)

Browse Source 
Typically only unit test frameworks do so.
This commit is contained in:
Haoqun Jiang
2019-10-10 10:00:31 +08:00
committed by GitHub
parent 617dd04cb4
commit da9269b328
3 changed files with 21 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
packages/@vue/babel-preset-app/index.js
View File

@@ -32,6 +32,21 @@ module.exports = (context, options = {}) => {
const plugins = []
const defaultEntryFiles = JSON.parse(process.env.VUE_CLI_ENTRY_FILES || '[]')
// Though in the vue-cli repo, we only use the two envrionment variables
// for tests, users may have relied on them for some features,
// dropping them may break some projects.
// So in the following blocks we don't directly test the `NODE_ENV`.
// Rather, we turn it into the two commonly used feature flags.
if (process.env.NODE_ENV === 'test') {
// Both Jest & Mocha set NODE_ENV to 'test'.
// And both requires the `node` target.
process.env.VUE_CLI_BABEL_TARGET_NODE = 'true'
// Jest runs without bundling so it needs this.
// With the node target, tree shaking is not a necessity,
// so we set it for maximum compatibility.
process.env.VUE_CLI_BABEL_TRANSPILE_MODULES = 'true'
}
// JSX
if (options.jsx !== false) {
presets.push([require('@vue/babel-preset-jsx'), typeof options.jsx === 'object' ? options.jsx : {}])
@@ -134,8 +149,10 @@ module.exports = (context, options = {}) => {
// cli-plugin-jest sets this to true because Jest runs without bundling
if (process.env.VUE_CLI_BABEL_TRANSPILE_MODULES) {
envOptions.modules = 'commonjs'
// necessary for dynamic import to work in tests
plugins.push(require('babel-plugin-dynamic-import-node'))
if (process.env.VUE_CLI_BABEL_TARGET_NODE) {
// necessary for dynamic import to work in tests
plugins.push(require('babel-plugin-dynamic-import-node'))
}
}
// pass options along to babel-preset-env

2
packages/@vue/cli-plugin-unit-jest/index.js
View File

@@ -9,7 +9,7 @@ module.exports = api => {
`All jest command line options are supported.\n` +
`See https://facebook.github.io/jest/docs/en/cli.html for more details.`
}, (args, rawArgv) => {
// for @vue/babel-preset-app
// for @vue/babel-preset-app <= v4.0.0-rc.7
process.env.VUE_CLI_BABEL_TARGET_NODE = true
process.env.VUE_CLI_BABEL_TRANSPILE_MODULES = true
require('jest').run(rawArgv)

2
packages/@vue/cli-plugin-unit-mocha/index.js
View File

@@ -42,7 +42,7 @@ module.exports = api => {
if (inspectPos !== -1) {
nodeArgs = rawArgv.splice(inspectPos, inspectPos + 1)
}
// for @vue/babel-preset-app
// for @vue/babel-preset-app <= v4.0.0-rc.7
process.env.VUE_CLI_BABEL_TARGET_NODE = true
// start runner
const { execa } = require('@vue/cli-shared-utils')