mirror/webgui
1
0
Fork 0
mirror of https://github.com/unraid/webgui.git synced 2026-01-06 01:29:54 -06:00
Code Issues Packages Projects Releases Wiki Activity

refactor: replace hardcoded icon fallback with a centralized default icon variable in MainContent.php for improved maintainability

Browse Source
This commit is contained in:
Zack Spear
2025-04-08 13:47:35 -07:00
parent 67d1471929
commit 2b7b6f437f
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
emhttp/plugins/dynamix/include/DefaultPageLayout/MainContent.php
View File

@@ -4,15 +4,17 @@
* Handles the rendering of tabs and page content.
*/
$defaultIcon = "<i class=\"icon-app PanelIcon\"></i>";
// Helper function to process icon
function process_icon($icon, $docroot, $root) {
global $defaultIcon;
if (substr($icon, -4) == '.png') {
if (file_exists("$docroot/$root/images/$icon")) {
return "<img src=\"/$root/images/$icon\" class=\"PanelImg\">";
} elseif (file_exists("$docroot/$root/$icon")) {
return "<img src=\"/$root/$icon\" class=\"PanelImg\">";
}
return "<i class=\"icon-app PanelIcon\"></i>";
return $defaultIcon;
} elseif (substr($icon, 0, 5) == 'icon-') {
return "<i class=\"$icon PanelIcon\"></i>";
} elseif ($icon[0] != '<') {
@@ -63,7 +65,7 @@ $tabbed = $display['tabs'] == 0 && count($pages) > 1;
$pgs = find_pages($page['name']);
foreach ($pgs as $pg):
@eval("\$title=\"".htmlspecialchars($pg['Title'])."\";");
$icon = _var($pg, 'Icon', "<i class=\"icon-app PanelIcon\"></i>");
$icon = _var($pg, 'Icon', $defaultIcon);
$icon = process_icon($icon, $docroot, $pg['root']); ?>
<div class="Panel">
<a href="/<?= $path ?>/<?= $pg['name'] ?>" onclick="$.cookie('one','tab1')">