Commit Graph

59977 Commits

Author SHA1 Message Date
Alex Turbov
69918b07e1 cmDocumentationEntry: Drop all user provided ctors for C++ >= 14
There is no need for them cuz:

- the last field has a default value
- all static instances use 2 arguments convertible to `std::string`
- "dynamic" instances used for _Generator_ doc entries access
  fields diectly using default constructed instance

Moreover, compiler may generate move ctor/assign when needed.
2022-11-17 16:37:12 +04:00
Alex Turbov
439d2cf9cb cmake.cxx: Optimize calls to std::osteam::operator<< 2022-11-17 16:37:12 +04:00
Alex Turbov
e06bd68b36 cmDocumentationFormatter: Hide internal methods into private section 2022-11-17 16:37:12 +04:00
Alex Turbov
5ef97a0182 cmDocumentation: Drop unused SetSections method 2022-11-17 16:37:11 +04:00
Alex Turbov
74b735dea8 cmDocumentation: char*[][2]cmDocumentationEntry[N]
Use fixed size arrays of `cmDocumentationEntry` items instead of
open arrays of two `char` pointers when describe program options
help screens.

Also, drop `const char*[][2]` overloads of methods of
`cmDocumentation` and `cmDocumentationSection` classes in the sake
of generic (template) appenders introduced earlier.
2022-11-17 16:37:11 +04:00
Alex Turbov
807aa8e353 CMakeSetup.cxx: Use anonymous namespace instead of static 2022-11-17 16:37:11 +04:00
Alex Turbov
96dcfa6b44 ccmake.cxx: Use anonymous namespace instead of static 2022-11-17 16:37:11 +04:00
Alex Turbov
8e2a03c078 ctest.cxx: Eliminate redundand trenary operator 2022-11-17 16:37:11 +04:00
Alex Turbov
9ae6569bfe ctest.cxx: Optimize std::ostream::operator<< calls 2022-11-17 16:37:10 +04:00
Alex Turbov
fddc48dd26 ctest.cxx: Use anonymous namespace instead of static arrays 2022-11-17 16:37:10 +04:00
Alex Turbov
95a3d91e5c cmakemain.cxx: Remove always true preprocessor #if block 2022-11-17 16:37:10 +04:00
Alex Turbov
ccff0b87a2 cmDocumentation: Accept Iterable instead of vector on add entries 2022-11-17 16:37:10 +04:00
Alex Turbov
067dcb9efd cmDocumentationSection: Accept Iterable instead of vector on add 2022-11-17 16:37:10 +04:00
Alex Turbov
09fdfe5afa cmDocumentationFormatter: Improve PrintFormatted
Instead of one char at time copy (append), use lines.
2022-11-17 16:37:10 +04:00
Alex Turbov
3feac60591 cmDocumentationFormatter: All printing methods accept strings 2022-11-17 16:37:09 +04:00
Alex Turbov
21c3e2107d cmDocumentationFormatter: Turn while () into for () loop 2022-11-17 16:37:09 +04:00
Alex Turbov
c802bfc548 cmDocumentationFormatter: Eliminate one if in the PrintColumn loop 2022-11-17 16:37:09 +04:00
Alex Turbov
f27537ec3d cmDocumentationFormatter: Turn TextWidth member into size_t
Cuz normally required text width can't be negative. It was `int`…
2022-11-17 16:37:09 +04:00
Alex Turbov
84241189f6 cmDocumentationFormatter: Prevent indentation reset side effect
Fix `cmDocumentationFormatter::PrintColumn()` method to eliminate
an indentation reset side effect.
2022-11-17 16:37:09 +04:00
Alex Turbov
bbe854a45a cmDocumentation: Drop useless call to formatter's SetIndent()
The `cmDocumentationFormatter::PrintSection()` method ignores
the currently set indentation level and use it's own.
2022-11-17 16:37:09 +04:00
Alex Turbov
cf39773df9 cmDocumentationFormatter: Turn TextIndent member into size_t
… instead of `std::string`.
2022-11-17 16:37:07 +04:00
Alex Turbov
1d6c8797fc cmDocumentationFormatter: Use std::ostream padding capabitily
… instead of manually print spaces to align fields.
2022-11-17 16:35:01 +04:00
Alex Turbov
5f3f811836 cmDocumentationFormatter: TextIndent member is std::string now
Was `const char*`.
2022-11-17 16:23:36 +04:00
Alex Turbov
b0fe4036b7 cmDocumentationFormatter: PrintPreformatted accept string
Also, make it `const` method cuz it's not modify the state.
2022-11-17 16:23:35 +04:00
Alex Turbov
3be0d77cc4 cmDocumentationFormatter.h: No need virtual methods
Can be added later it really need.
Also, drop ctor/dtor to make the class trivially destructable.
2022-11-17 16:23:35 +04:00
Alex Turbov
3bff44ffd3 cmDocumentationEntry.h: Drop unused constructor 2022-11-17 16:23:35 +04:00
Alex Turbov
f074e2bd49 cmDocumentation: Optimize std::ostream::operator<<() calls 2022-11-17 16:23:35 +04:00
Alex Turbov
8ab0168cbc cmDocumentation.cxx: Use lambda function instead of macro 2022-11-17 16:23:35 +04:00
Alex Turbov
049b017c5d cmDocumentation.cxx: Use anonymous namespace instead of static 2022-11-16 18:37:05 +04:00
Alex Turbov
30bcdafaef cmDocumentation: Remove MSVC 6 workaround 2022-11-16 18:37:05 +04:00
Brad King
e2f12b6c8b Merge branch 'release-3.25' 2022-11-16 08:59:14 -05:00
Brad King
c5a94e730a Merge topic 'qtifw-4.5'
351239b776 CPack/IFW: Add support for QtIFW 4.5

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7920
2022-11-16 08:59:13 -05:00
Brad King
7621eec766 Merge topic 'qtifw-4.5' into release-3.25
351239b776 CPack/IFW: Add support for QtIFW 4.5

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7920
2022-11-16 08:59:13 -05:00
Brad King
facd621db2 Merge branch 'release-3.25' 2022-11-16 08:57:04 -05:00
Brad King
b686b58208 Merge topic 'cmp0141-pch-reuse'
94164ea55e CMP0141: Fix PCH REUSE_FROM when MSVC_DEBUG_INFORMATION_FORMAT is empty

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7914
2022-11-16 08:57:04 -05:00
Brad King
23183a6ad7 Merge topic 'cmp0141-pch-reuse' into release-3.25
94164ea55e CMP0141: Fix PCH REUSE_FROM when MSVC_DEBUG_INFORMATION_FORMAT is empty

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7914
2022-11-16 08:57:03 -05:00
Kitware Robot
b7ab39bf59 CMake Nightly Date Stamp 2022-11-16 00:01:11 -05:00
Erlend E. Aasland
351239b776 CPack/IFW: Add support for QtIFW 4.5
Fixes: #24164
2022-11-15 16:30:50 -05:00
Brad King
88c4006f05 Merge topic 'ci-continuous'
6cf026ab06 ci: add macos-x86_64-ninja build and test jobs to continuous pipeline

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7915
2022-11-15 10:02:30 -05:00
Brad King
6cf026ab06 ci: add macos-x86_64-ninja build and test jobs to continuous pipeline 2022-11-15 09:21:58 -05:00
Brad King
0ebee2a14b Merge topic 'ci-openmp-macos'
7ef3638454 ci: Enable FindOpenMP tests on macOS Ninja and Makefiles jobs

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7912
2022-11-15 09:14:46 -05:00
Brad King
eda68d229d Merge topic 'cmake-E-copy-t-mode'
8d9069e5b6 cmake -E copy: Add support for -t argument

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7913
2022-11-15 09:14:07 -05:00
Brad King
cf0f704683 Merge topic 'clang-tidy-module-ostringstream-check'
0880114ada clang-tidy: disable ostringstream check
75ab77ee19 clang-tidy module: add test for ostringstream check
04638e7358 clang-tidy module: add check for ostringstream

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7911
2022-11-15 09:12:50 -05:00
Brad King
3379723239 Merge topic 'test-isolate-ctest-env'
e46a9d79fc Tests: Isolate more RunCMake cases from external ctest environment values
3b6c1c1a3b Tests: Factor out RunCMake ctest environment isolation

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !7909
2022-11-15 09:11:10 -05:00
Brad King
6f9544736a Merge topic 'better_handling_of_build_args'
01611f8258 cmake: --build improve detection of no build dir

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !7908
2022-11-15 08:55:19 -05:00
Brad King
5dbc7be0da Merge topic 'legacy'
a44d415ed3 CMakeDetermineSystem: use execute_process() vs. exec_program()

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7884
2022-11-15 08:53:50 -05:00
Brad King
82e49021fe Merge topic 'top-level-command-order'
59573bf5b9 project: Warn at top-level if `cmake_minimum_required` wasn't called
23f3dd9f7c RunCMake/project: Ignore exact line number in stderr checks

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7902
2022-11-15 08:51:20 -05:00
Brad King
e58936fd6d Merge topic 'lcc-cleanup'
84eebdf18e Tests: Teach CheckSourceTree test to clean up more specific known files

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7907
2022-11-15 08:49:41 -05:00
Kyle Edwards
8d9069e5b6 cmake -E copy: Add support for -t argument
Fixes: #23543
2022-11-15 07:47:07 -05:00
Brad King
94164ea55e CMP0141: Fix PCH REUSE_FROM when MSVC_DEBUG_INFORMATION_FORMAT is empty
Under the policy's NEW behavior, `[CMAKE_]MSVC_DEBUG_INFORMATION_FORMAT`
may be explicitly set to an empty string to tell CMake not to add any
flags for this abstraction.  In this case, fall back to checking the
language-wide flags as we do in the OLD behavior.

This revises commit 183b9a9eca (CMP0141: Fix PCH REUSE_FROM under policy
NEW behavior, 2022-10-31, v3.25.0-rc3~4^2).

Issue: #24106
2022-11-15 06:57:02 -05:00