mirror/Checkmate
1
0
Fork 0
mirror of https://github.com/bluewave-labs/Checkmate.git synced 2026-05-19 07:58:46 -05:00
Code Issues Packages Projects Releases Wiki Activity

Nitpick fix - ref -

Browse Source 
client/src/Pages/v1/Settings/index.jsx (1)
171-175: LGTM!

The Redux dispatch provides immediate UI feedback while the actual persistence happens on Save. This is the correct pattern for a server-persisted setting.

Minor note: The ?? value fallback is unreachable for showURL since newValue is always set to a boolean at line 96. Consider simplifying to dispatch(setShowURL(newValue)) for clarity, though the current code is functionally correct.
This commit is contained in:
Craig Lawson
2026-01-11 22:36:05 +00:00
parent b6f48a910f
commit a70959e4a6
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/Pages/v1/Settings/index.jsx
+1 -5
View File
@@ -171,11 +171,7 @@ const Settings = () => {
// Update Redux immediately for UI feedback
if (name === "showURL") {
dispatch(setShowURL(newValue ?? value));
}
};
const handleSave = () => {
dispatch(setShowURL(newValue));
const { error } = settingsValidation.validate(settingsData.settings, {
abortEarly: false,
});