3ce40b1ab8
Fix handleSave function syntax errors
2026-01-11 22:48:17 +00:00
1494df9eb3
missing brace
2026-01-11 22:39:49 +00:00
a70959e4a6
Nitpick fix - ref -
...
client/src/Pages/v1/Settings/index.jsx (1)
171-175: LGTM!
The Redux dispatch provides immediate UI feedback while the actual persistence happens on Save. This is the correct pattern for a server-persisted setting.
Minor note: The ?? value fallback is unreachable for showURL since newValue is always set to a boolean at line 96. Consider simplifying to dispatch(setShowURL(newValue)) for clarity, though the current code is functionally correct.
2026-01-11 22:36:05 +00:00
b6f48a910f
Revert caching changes - restore working implementation
...
- Remove settingsModule caching that caused inconsistent state
- Restore direct AppSettings query in statusPageModule
- Keep immediate Redux dispatch for UI feedback
- All functionality verified working"
2026-01-11 22:08:15 +00:00
e4d101237e
bug fix - settings handlechange
2026-01-11 21:51:59 +00:00
7556086f71
code review updates
...
Summary of what we fixed based on AI review feedback:
Formatting - Ran Prettier to fix code formatting
Redux state rollback - Moved Redux dispatch to after successful save in settingsHooks.js
Performance - Added caching layer in settingsModule (1-minute TTL) to prevent DB query on every status page request
Architecture - Inject settingsModule instead of raw AppSettings model for better encapsulation
2026-01-11 20:51:25 +00:00
7b619e6b31
Remove debug logging and add feature documentation
...
- Remove all console.log statements added during development
- Clean up code for production readiness
2026-01-11 18:56:16 +00:00
76ab2695db
missing setting
2026-01-11 18:23:58 +00:00
418068e702
loggin settings
2026-01-11 18:18:38 +00:00
12b28ffb3f
type issue
2026-01-10 22:30:03 +00:00
526fa24eab
validation bug
2026-01-10 22:23:31 +00:00
a13f6a34c4
missing value
2026-01-10 22:02:36 +00:00
f659876845
select bug
2026-01-10 21:58:13 +00:00
643a743d70
more logging
2026-01-10 21:49:10 +00:00
ab4cc80628
3120 persist admin value
2026-01-10 21:29:15 +00:00
fb3795bd70
3120 remove URL's from data when they are supposed to be disabled
2026-01-10 12:15:29 +00:00
5c14c68899
Merge pull request #3119 from bluewave-labs/fix/controllerUtils
...
js -> ts
2026-01-09 15:59:18 -08:00
5a878e89d0
Merge pull request #3118 from bluewave-labs/fix/check-controller
...
js->ts
2026-01-09 15:58:45 -08:00
bdb07220ed
js -> ts
2026-01-09 15:58:31 -08:00
641d5e6dda
Merge pull request #3117 from bluewave-labs/fix/diagnostic-controller
...
js->ts
2026-01-09 15:54:02 -08:00
b24339f232
js->ts
2026-01-09 15:53:53 -08:00
ff324fe6e7
Merge pull request #3116 from bluewave-labs/fix/incidentController
...
js->ts
2026-01-09 15:46:39 -08:00
fee9b8a0de
js->ts
2026-01-09 15:46:30 -08:00
ad9488f54e
Merge pull request #3115 from bluewave-labs/fix/invite-controller
...
js -> ts
2026-01-09 15:44:23 -08:00
ed77fc3a9d
js->ts
2026-01-09 15:44:11 -08:00
babd8e672f
Merge pull request #3114 from bluewave-labs/fix/log-controller
...
js->ts
2026-01-09 15:39:35 -08:00
8ceac493ef
js -> ts
2026-01-09 15:39:30 -08:00
fee808789f
Merge pull request #3113 from bluewave-labs/fix/mw-controller
...
js->ts
2026-01-09 15:35:53 -08:00
dd03c554c9
js->ts
2026-01-09 15:35:48 -08:00
3ab4fcb277
js->ts
2026-01-09 15:32:53 -08:00
11e3cac440
Merge pull request #3112 from bluewave-labs/fix/status-page-controller
...
js->ts
2026-01-09 15:26:37 -08:00
1d7f3b15a4
js->ts
2026-01-09 15:21:56 -08:00
b7ad3c036b
Merge pull request #3111 from bluewave-labs/fix/settings-controller
...
js->ts
2026-01-09 15:20:30 -08:00
7b2ff593a4
js->ts
2026-01-09 15:16:17 -08:00
916f3c0921
Merge pull request #3110 from bluewave-labs/feat/queue-controller
...
Feat/queue controller
2026-01-09 15:13:31 -08:00
846f1dfa6c
remove extra param
2026-01-09 15:07:38 -08:00
3f631ff382
js -> ts
2026-01-09 15:07:02 -08:00
43a370e162
Merge pull request #3109 from bluewave-labs/feat/notification-controller
...
js -> ts
2026-01-09 15:05:13 -08:00
64320c7aca
js -> ts
2026-01-09 15:02:19 -08:00
61cedfb2b7
Merge pull request #3108 from bluewave-labs/feat/monitor-controller
...
monitor controller -> ts
2026-01-09 14:51:17 -08:00
a9ce980d03
monitor controller -> ts
2026-01-09 14:49:44 -08:00
8409f08a2d
Merge pull request #3107 from bluewave-labs/feat/be/ts
...
ts config
2026-01-09 13:38:55 -08:00
ef2cccf16e
ts config
2026-01-09 13:36:58 -08:00
668ea7418d
Merge pull request #3088 from bluewave-labs/fix-traslator-error
...
fix translator error and add format
2025-12-22 09:41:58 -08:00
b12bdfcc22
fix traslator error and add format
2025-12-22 12:36:29 -05:00
65de627870
Merge pull request #3079 from Antoplt/feat/choose-disks-monitor
...
feature requested #2840 : improve disk device and mountpoint display with hover tooltips
2025-12-18 10:53:24 -08:00
03d1dcaefb
Merge branch 'develop' into feat/choose-disks-monitor
2025-12-18 10:53:01 -08:00
14768bde28
Merge pull request #3086 from bluewave-labs/fix-incidents-duplication-front-end
...
Fix incidents duplication front end
2025-12-18 10:51:52 -08:00
9555ff43c7
add llama suggestions and fix genericFallback error
2025-12-18 12:47:01 -05:00
75acb1ade6
Merge branch 'develop' into fix-incidents-duplication-front-end
2025-12-17 18:56:25 -05:00
Craig Lawson