* Fix faulty log category and minor inconsistencies in GlobeTranslation and GlobeRotation
* Small refactor
* Remove unused return value from initialize function
* Fill attached node in globetranslation initialize and initialize all timeline
Should make the timeline translation work with globetranslations in other cases that the renderabletrails
* Do the same type of change for rotation and scale
* Update initialize function singatures
* Initialize and update translation in trail before use
* Screenspace renderable renderable - move initialize call to initialize
* Refactor trail position calls to make it clearer what is being done
* Call timeframe initialize functions in transform classes
* Do not call update in trail position after all - it borks up the performance
* GlobeTransform: Only fill attached node in init and onchange, and allow nodes without renderable
* Correctly initialize the multi-transform types
* Apply suggestions from code review
* Apply suggestions from code review
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
* Address code review comment
* Update comments in renderabletrail
---------
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
* Notify change listeners
I can't come up with a reason for why we would not want to do this
* Remove the Display Type for OptionProperty (only used in ImGui)
* Replace extra boolean with internal anonymous addOption function
* Tiny refactor
* removed dropdown on a couple of more places
* Update optionproperty.cpp
---------
Co-authored-by: ElonOlsson <olssonelon@gmail.com>
A passover of all the Parameters descriptions and PropertyInfo descriptions of the renderables in the code base to make then more consistently and concisely formatted. Also fixed some small issues and added or updated descriptions.
* Start rephrasing propertyinfos for more consistency
* Update eclipse cone propertyinfos
* Update `RenderableFov` property infos and group colors in UI
* `RenderableGalaxy` and `RenderableGlobe`
* Update more descriptions
* Moore descriptions
* Update docs for `RenderableShadowCylinder` and add properties
* `RenderableSkyTarget`, and spheres (`ImageOnline` and `ImageLocal`)
* `RnederableSphericalGrid`, and update line width info of other types, for consistency
* `RenderableStars` and `RenderableTimeVaryingSphere`
* Update more propertyinfos
* Fix inconsistent mentioning of true/false
* change some phrasings for increased consistency
* Update Renderbin description to include Sticker bin and remove extra property
* Rename `OutlineWeight` -> `OutlineWidth`
* Extend description about enable depth test for models
* Clarify what relative values mean for `RenderableNodeArrow`
* Elaborate on `RenderableLabel` size property
---------
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
Co-authored-by: Ylva Selling <ylva.selling@gmail.com>
Co-authored-by: Malin E <malin.ejdbo@gmail.com>
Fixes following issues: #625 , #1067 , #1212 , #1472 , #2072 , #2235, #2964
- Trails in `renderableTrailTrajectory` now goes through the spacecraft when using `AccurateTrailPositions`.
- Trail fading controls have been improved for classes using the `renderableTrail` class.
- `renderableOrbitalKepler` (asteroids/satellites) can now be rendered as both trails and points (or both at once). Solution implements similar functionality/controls as `renderablePointCloud`.
- Default setting for SweepChunking has been changed from `true` to `false` (iterative calculations of `renderableTrailTrajectory`).
- Some fixes related to missing points or off-by-one errors related to trail rendering
* Split RenderableSphere class into a local and an online sphere
* Make the video sphere derive from the regular sphere
* Make RenderableTimeVaryingSphere derive from RenderableSphere
* Some clean up
* Add general functions for renderable matrix calculations
* Make RenderableSphere and Plane use them
* Fix an issue with the RenderablePlane shader
* Make one function that returns all three types of render matrices
* Make more Renderables use the general matric calculation function
* Make more Renderable use the general matrix function
* Simplify alternative transforms for matrix calculations
* Small clean-up
* Update RenderableModel (again) to use new transform functions
* Make calc all matrix function to return tuple
* Update some more places
* Change name of line fade in RenderableTrail from Fade to LineFade
* Adress review comments
---------
Co-authored-by: Emma Broman <emma.broman@liu.se>
* Add settings to Renderable to control whether the renderbin is updated based on Opacity
* Remove duplicate RenderBin specification for RenderableSphere
* Remove unnecessary RenderBin specifications of Lagrange points
* Don't automatically update the renderbin for RenderableLabel and RenderablePlane
* Remove extra `setRenderBinFromOpacity` from RenderableSpheres
* Move information about whether a renderable should be updated when disabled
* Some cleanup of Renderable class
* Don't update the renderbin automatically if the user specified the renderbin manually
- Add a new Color3Verifier and Color4Verifier that checks components to be in [0,1]
- Update codegen to add a new attribute [[codegen::color()]] to mark a vec3/vec4 to be a color value
- Update RenderableTrail to use the new verion
* Add the ability to automatically generate code to extract values out of a Dictionary (see https://github.com/openspace/codegen for more information on how to use this)
* Applied this technique to a large number of cases in the codebase
* Don't add _codegen files to the repository
Co-authored-by: Emma Broman <emma.broman@liu.se>
* Adapting to introduction of new Dictionary class in Ghoul
* Mainly replacing usage of float instead of doubles as expected
* Adjust to the lack of the hasKeyAndValue function
* Add ability to toggle operating system builds on Jenkins via environment variables
* Update ghoul repository
* Update SGCT repository
* Reduce chattiness of the Jenkins log file
* Build native and ninja builds in parallel
* Disable ninja build on Windows as it fails with the OpenSpace Helper
* Cleaner handling of global state
* Prevent Lua memory corruption (closes#982)
* Initialize glfw first thing to prevent weird joystick loading bug during startup