* Move exoplanet creation code to Lua
* Add more descriptions and handle missing values
* Remove old creation function and move load from CSV to Lua
* Properly document all functions, including a type for the `systemData` return value
* Add `\param` documentation to the scripts
* Cleanup and move helper functions to core scripts
* Throw Lua errors when things go wrong, instead of returning empty objects
This prevents the rest of the code from being run
* Flesh out TODO comments, so future us know why they are there
---------
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
# To run the script
Make sure to install the latest Python API version `openspace-api 0.1.2`
The script is located in `OpenSpace/support/assetvalidation`, the main script takes a few command line arguments
`--dir` - specify the OpenSpace directory
`--filter` - optionally supply a regex string to filter which assets to validate
`--verbose` - flag to print debug info to log and also console (default off), if off only warnings and errors are logged
`--start` - flag to start OpenSpace as a subprocess (default on) if this is off it assumes OpenSpace is already running, useful if you want to run OpenSpace via Visual Studio for example.
`--at` - specify an index to start at a specific asset
run eg:
`python main.py --dir="C:/User/Desktop/OpenSpace" --filter="examples" --verbose=True --start=False --at=35`
* Do not hide requestedUnit of dashboarditem distance in UI
We want to be able to change it during runtime
* Change visiblity of RequestedUnit properties
* Add a tag for all exoplanet globes
* Add color to exoplanet globes based on their size
* Update color of terrestrial planets to be more deeply brown
* Change order so that the default texture for planets is shown on top
I.e. only use color if no other texture was provided
* Add descriptions of layer and planet type
* Add descriptions for some more things in the system
* Increase ambient intensity for when a planet is colored (not textured)
* Ignore GlobeBrowsing shader warning when setting camera position (closes#3405)
* Apply suggestions from code review
* Fix new constant names (from review)
---------
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
* Restructure "general properties" into shadow mapping and regular ones
To better connect to subpropertyowners and avoid having to specify an ordered list in constructor... Hard to keep track of
* Restructure properties in constructor to more easily find errors
* Add values that could not be set from parameters (e.g. from asset or script)
* Apply suggestions from code review
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
* Address review comments
---------
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
* Restructuring the queueScript function
* Don't log the contents of actions that are triggered. Add the ability to do verbose logging in the scriptlog
* Update CEF version number
* Set OpenSpace_Helper version of C++ to 20
* Update C++ syntax to v 20
* Remove deprecated function (now default)
* Set the cache folder for cef
* Make static function in webbrowsermodule that determines if we can use accelerated rendering
* Add flag for accelerated rendering to webrenderhandler
* Use accelerated rendering
* Implement function to see if gui should absorb click
* Adhere to 80 char linewidth
* Make only the UI GPU accelerated
* Use dirty rects size for the texture to remove crash
* Better comments
* Make has content function work for GPU acceleration
* Make it so all browsers can be accelerated
Tried making it so only the gui was accelerated for simplicity. Performance plummeted, so reverted that
* Tidy up
* Add accelerated rendering flag to the screenspacerenderable shader
* Add temporary fix to make the sky browser work
* Remove flag from gui render handler
* Enable webgl in a nicer way
* Unbind texture in screenspacerenderable
* Add better comments for error handling
* Tidy up
* Address PR comments
* Make the acceleration Windows only
* Remove unnecessary setting of shader dictionary
* Add display handler to browser client
* Make glfw change mouse cursor depending on cef cursor
* formatting
* Add switch to main
* Update modules/webbrowser/src/browserclient.cpp
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
* Address comments on PR
* Update again
* Update modules/webbrowser/src/browserclient.cpp
Co-authored-by: Emma Broman <emma.broman@liu.se>
* Address PR comments
---------
Co-authored-by: Ylva Selling <ylva.selling@liu.se>
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
Co-authored-by: Emma Broman <emma.broman@liu.se>
* Update CEF version number
* Set OpenSpace_Helper version of C++ to 20
* Update C++ syntax to v 20
* Remove deprecated function (now default)
* Set the cache folder for cef
* Make static function in webbrowsermodule that determines if we can use accelerated rendering
* Add flag for accelerated rendering to webrenderhandler
* Use accelerated rendering
* Implement function to see if gui should absorb click
* Adhere to 80 char linewidth
* Make only the UI GPU accelerated
* Use dirty rects size for the texture to remove crash
* Better comments
* Make has content function work for GPU acceleration
* Make it so all browsers can be accelerated
Tried making it so only the gui was accelerated for simplicity. Performance plummeted, so reverted that
* Tidy up
* Add accelerated rendering flag to the screenspacerenderable shader
* Add temporary fix to make the sky browser work
* Remove flag from gui render handler
* Enable webgl in a nicer way
* Unbind texture in screenspacerenderable
* Add better comments for error handling
* Tidy up
* Address PR comments
* Make the acceleration Windows only
* Remove unnecessary setting of shader dictionary
* Allow web dev tools to connect to CEF
* Update modules/webbrowser/include/browserinstance.h
Co-authored-by: Emma Broman <emma.broman@liu.se>
* Update modules/webbrowser/include/webrenderhandler.h
Co-authored-by: Emma Broman <emma.broman@liu.se>
* Apply suggestions from code review
Co-authored-by: Emma Broman <emma.broman@liu.se>
---------
Co-authored-by: Ylva Selling <ylva.selling@liu.se>
Co-authored-by: Emma Broman <emma.broman@liu.se>
* remove code for controlling group sorting in ImGui
We only use this for debug and the sorting here is no longer relevant
* Add feature to add custom ordering to UI groups
* Tiny cleanup
* Add numerical ordering for night sky planets
* Update Lua function name and create an event when ordering updated
* Set top-level ordering
* Add function documentation
* Add a custom ordering that previously was hardcoded in UI
* Apply suggestions from code review
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
* Rename GUI ordering function
* Update GUI hash
---------
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
* Update CEF version number
* Set OpenSpace_Helper version of C++ to 20
* Update C++ syntax to v 20
* Remove deprecated function (now default)
* Set the cache folder for cef
* Update modules/webbrowser/src/cefhost.cpp
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
* Update version number
---------
Co-authored-by: Ylva Selling <ylva.selling@liu.se>
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
* Remove events for scenegraphnodes and screenspacerenderables
* Add events for updating the property tree
* Remove duplicate function calls
* Update src/properties/propertyowner.cpp
Co-authored-by: Emma Broman <emma.broman@liu.se>
* Address PR comments and make helper functions with better comments
* Make uri function not return the identifier if the uri is not valid
* Rename fullyQualifiedIdentifier to uri
* Update gui hash
---------
Co-authored-by: Ylva Selling <ylva.selling@liu.se>
Co-authored-by: Emma Broman <emma.broman@liu.se>
* Add possibility to specify a default texture for added exoplanets
* Warn if exoplanet texture does not exists and provide more user friendly warnings
* Address review comments
* Add a disables label for the star for all added exoplanet systems
* Refactor queue script code a bit, to reduce duplicate code
* Apply suggestions from code review
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
---------
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
Andreas Engberg