Commit Graph

415 Commits

Author SHA1 Message Date
Klaas van Schelven
d4b4e631fb Note a TODO 2024-04-15 09:14:26 +02:00
Klaas van Schelven
280bd2172b History page: 'mostly done' (a first setup) 2024-04-12 16:07:25 +02:00
Klaas van Schelven
a9557201b1 Fix _is_valid_action 'typo' 2024-04-12 11:34:12 +02:00
Klaas van Schelven
1cf19c83d5 Various code-clarification 2024-04-12 08:38:46 +02:00
Klaas van Schelven
b178573d35 fix on show_toolbar_for_queryparam
when showing a DJDT panel, it should always be shown. The (potential) hiding
should just be on our own pages
2024-04-11 11:48:22 +02:00
Klaas van Schelven
47e8318177 Remove event-list from issue tabs
at least postponed for now: we can navigate between events with the arrows,
and if we want more advanced ways of reaching particular events we may end
up implementing that using the more general 'search' interface
2024-04-11 11:23:08 +02:00
Klaas van Schelven
83eec6854d Use logger in middleware to avoid cluttering the tests with print statements 2024-04-11 11:19:13 +02:00
Klaas van Schelven
f098802fde Event already exists: return 400; implement with one less query 2024-04-11 11:03:41 +02:00
Klaas van Schelven
d2a17912d2 Rename templates for brevity 2024-04-10 12:01:01 +02:00
Klaas van Schelven
a4b0109e91 queryparam-based conditionally show DJDT
I like my tooling out-of-the-way
2024-04-10 11:37:22 +02:00
Klaas van Schelven
e8032483db Turn off guess_lexer for now 2024-04-10 11:23:39 +02:00
Klaas van Schelven
7874b6fa89 Simple Middleware for performance tracking 2024-04-10 11:06:58 +02:00
Klaas van Schelven
9d9f3816e3 Show 'logger' if this info is available
Somewhat untested, we used to have this in a very early version ("Emitted by")
and it was removed when converting into the calculated_xx style. I haven't found
any recent sample events that have this value but according to the spec it can
exist so I'm putting it back in.
2024-04-10 09:24:53 +02:00
Klaas van Schelven
13445324b8 Dead code removal
we do the whole of the 'log entry' stuff using the calculated_type and _value now
2024-04-10 09:20:46 +02:00
Klaas van Schelven
4dfefec468 denormalize/cache last_frame_* and transaction on Event and Issue
for performance, but also fixes:

* not just the 'last frame' but the 'last relevant frame' (in-app)
* truncation is properly done (matching the DB size, and for each of the fields)
2024-04-10 09:12:15 +02:00
Klaas van Schelven
ba6b158848 Fix on previous commit (wrong unique index) 2024-04-10 08:54:58 +02:00
Klaas van Schelven
eb1bcbcbf6 Configure django-debug-toolbar 2024-04-09 12:46:00 +02:00
Klaas van Schelven
b5babbda84 Event: urls match on external (sdk) event_id too 2024-04-09 12:37:25 +02:00
Klaas van Schelven
d46cb7f6e8 DB: unique_together and PositiveIntegerField 2024-04-09 12:34:29 +02:00
Klaas van Schelven
21c4904524 Implement friendly_id 2024-04-09 11:09:31 +02:00
Klaas van Schelven
72b65f73e4 Shift tabs around
Breadcrumbs left. Reasoning: it's an event-based page, should go with the others.
(Counterarg being: I dislike breadcrumbs)

History right. Having the historic view be the right-most "just feels right"
2024-04-09 09:43:35 +02:00
Klaas van Schelven
82b8c014e7 Add title to event-details 2024-04-09 09:39:50 +02:00
Klaas van Schelven
e9d5913c17 Event details: IDs and timestamps 2024-04-09 09:28:23 +02:00
Klaas van Schelven
1b37298a95 ingest_order: first setup 2024-04-08 22:13:52 +02:00
Klaas van Schelven
6d4b1beae4 Remove TODOs 2024-04-08 16:47:09 +02:00
Klaas van Schelven
f8d9aa736d Push 'get_title' into default_issue_grouper
this is in prepartion of an expected future where we allow for more customization
of the grouping behavior
2024-04-08 16:30:11 +02:00
Klaas van Schelven
4016f13c07 Move truncatechars to the only place we actually need it
i.e. when storing stuff in the DB (other cases are taken care of on-render
2024-04-08 16:22:00 +02:00
Klaas van Schelven
da3f0325a2 Grouping: expose the recent data-modelling work in the UI 2024-04-08 16:17:45 +02:00
Klaas van Schelven
e98dddf2c4 Use a denormalized field (event_count) in the admin that's been available for a while 2024-04-08 15:34:28 +02:00
Klaas van Schelven
cc3a119998 Remove TODO; I stopped doubting (for now)
issue.title is based on the first event, but if this ever becomes a problem
I should probably deal with it by making issue.title better (generic over the
events or even editable) and not by making an issue-page which changes its
display based on which event is selected
2024-04-08 15:33:07 +02:00
Klaas van Schelven
652823f8c3 Store calculated type and value on issue and event and use these values in the templates 2024-04-08 15:30:41 +02:00
Klaas van Schelven
729a4c7ea1 Make <no transaction> explicit;
and more moving-around-of-code in preparation for our next step
2024-04-08 15:03:02 +02:00
Klaas van Schelven
cb75d318af Remove the event_type_name from the grouper
it adds very little, especially now that we've put this information in the type
('Log Message') and removing this allows us to refactor more freely
2024-04-08 14:52:09 +02:00
Klaas van Schelven
8d17e7b128 For log messages, demote the msg into the value
and make the type 'Log Message'.
This may just be a matter of personal taste, but I've always found these
messages-as-type super-confusing. I'd rather have some made up (but clear,
and thanks to the whitespace unlikely-to-otherwise-exist) type "Log Message".

This is also inline in what I've already done in the UI.
2024-04-08 14:48:39 +02:00
Klaas van Schelven
a70ac7e1cb Factor out the idea (exception -> type_, value) what we have 2024-04-08 14:39:14 +02:00
Klaas van Schelven
77209bde5d truncatechars: just use the Django version 2024-04-08 14:36:34 +02:00
Klaas van Schelven
48307daa0f Introduce 'Grouping' data-modeling 2024-04-08 11:41:15 +02:00
Klaas van Schelven
226415ce43 Further simplications in ErrorEvent.get_title() 2024-04-05 16:03:10 +02:00
Klaas van Schelven
7caf6bbac4 docstring 2024-04-05 15:50:06 +02:00
Klaas van Schelven
9dfae5a829 Use the diamond-separator when generating fingerprint-based groupers too 2024-04-05 15:41:12 +02:00
Klaas van Schelven
54e8009e73 Reorganize/cleanup title-generating code for clarification 2024-04-05 15:37:24 +02:00
Klaas van Schelven
301c6416ea Remove class-hierarchy (in preparation for further cleanup) 2024-04-05 15:05:00 +02:00
Klaas van Schelven
80919d01b8 Remove the concept of 'culprit' from the grouping code
This has been deprecated in Sentry in 2016; no reason for us to support it.

It is noted that despite the deprecation (in favor of `transaction`) an
explicitly provided culprit actually took a higher precedence than an
explicitly provided transaction in the now-removed code.
2024-04-05 15:02:56 +02:00
Klaas van Schelven
eaa5ee6838 Tests for existing grouping functionality 2024-04-05 12:10:51 +02:00
Klaas van Schelven
2011006e74 Remove 'TODO' that was apparently already acted on 2024-04-05 11:13:08 +02:00
Klaas van Schelven
83c55e5f12 Remove unused base template 2024-04-05 10:13:56 +02:00
Klaas van Schelven
0729523cde Guess the pygments Lexer (using the filename) 2024-04-05 09:59:11 +02:00
Klaas van Schelven
aca522ef8f Document thoughts on the design of breadcrumbs 2024-04-05 09:14:06 +02:00
Klaas van Schelven
e263bcb96f 'No info available' for breadcrumbs 2024-04-05 09:10:33 +02:00
Klaas van Schelven
dfa92a5725 Comment-out trace info from detail view 2024-04-04 22:00:46 +02:00