mirror/dolt
1
0
Fork 0
mirror of https://github.com/dolthub/dolt.git synced 2026-01-30 10:45:18 -06:00
Code Issues Packages Projects Releases 124 Wiki Activity

Respond to PR comments.

Browse Source
This commit is contained in:
Nick Tobey
2025-02-24 19:32:02 -08:00
parent 4c3748c4e4
commit 743eb87fce
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
go/libraries/doltcore/sqle/tables.go
View File

@@ -1686,13 +1686,11 @@ func (t *AlterableDoltTable) columnChangeRequiresRewrite(oldColumn *sql.Column,
// TODO: we need to do this because some spatial type changes require a full table check, but not all.
// We could narrow this check down.
return true
} else if types.IsFormat_DOLT(t.Format()) {
} else {
// This is overly broad, we could narrow this down a bit
compatibilityChecker := typecompatibility.NewTypeCompatabilityCheckerForStorageFormat(t.Format())
typeChangeInfo := compatibilityChecker.IsTypeChangeCompatible(existingCol.TypeInfo, newCol.TypeInfo)
return !typeChangeInfo.Compatible || typeChangeInfo.RewriteRows || typeChangeInfo.InvalidateSecondaryIndexes
} else if existingCol.Kind != newCol.Kind {
return true
}
}