mirror/dolt
1
0
Fork 0
mirror of https://github.com/dolthub/dolt.git synced 2026-01-25 10:26:22 -06:00
Code Issues Packages Projects Releases 123 Wiki Activity

Merge pull request #5672 from dolthub/aaron/doltdb-table-always-write-new-table-value

Browse Source 
go/libraries/doltcore/doltdb: durable/table: Always write the table value we are refing. Ensures it always makes it across the GC safepoint.
This commit is contained in:
Aaron Son
2023-04-01 07:10:10 -07:00
committed by GitHub
parent fad22f9c56 e4558453aa
commit 75fa4579f5
1 changed files with 1 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
go/libraries/doltcore/doltdb/durable/table.go
View File

@@ -668,27 +668,7 @@ func (t nomsTable) DebugString(ctx context.Context) string {
}
func refFromNomsValue(ctx context.Context, vrw types.ValueReadWriter, val types.Value) (types.Ref, error) {
valRef, err := types.NewRef(val, vrw.Format())
if err != nil {
return types.Ref{}, err
}
targetVal, err := valRef.TargetValue(ctx, vrw)
if err != nil {
return types.Ref{}, err
}
if targetVal == nil {
_, err = vrw.WriteValue(ctx, val)
if err != nil {
return types.Ref{}, err
}
}
return valRef, err
return vrw.WriteValue(ctx, val)
}
func schemaFromRef(ctx context.Context, vrw types.ValueReadWriter, ref types.Ref) (schema.Schema, error) {