Commit Graph

3276 Commits

Author SHA1 Message Date
Martin Kleusberg 85e1d0863c tests: Clean up test cases 2020-06-23 16:36:53 +02:00
mgrojo a803069d5e Font change in Browse Data table not applied to RTL Text editor
See issue #2295
2020-06-22 12:39:52 +02:00
mgrojo efb5b1a07a Improve binary detection for cases starting by chance by a BOM
The presence of a sequence of bytes resembling a BOM does not guarantee
that the data is text. We can in those cases use the detection provided
by Qt. If the codec matches the one selected, we can consider that text.

See issue #2197
2020-06-21 23:18:09 +02:00
mgrojo f4d78ad786 Set savepoint before logging the SQL statement
Otherwise the sequence of savepoint and update statement is inverted in the
SQL log.

See issue  #1859
2020-06-21 17:56:43 +02:00
mgrojo 3485a52e16 Bar charts did not display labels in x axis when NULL values present
The problem was signaled by an error when calling addTicks:
[...]AddTicks[...] passed unequal length vectors for positions and labels

See comment in issue #2286
2020-06-20 16:59:39 +02:00
Martin Kleusberg 9481bd8ef6 tests: Activate more parser tests
Now that we have parser support for named constraints we can activate a
couple more tests.
2020-06-19 16:02:08 +02:00
Martin Kleusberg 26fc5ba7e8 parser: Add support for single quoted constraint names
This adds support for constraints with single quoted names (i.e. using
the string literal syntax).
2020-06-19 16:01:24 +02:00
Martin Kleusberg fb3a9a0638 parser: Simplify code
This removes no longer needed code like the handling of not fully parsed
column constraints. It simplifies the code even further by handling
constraints in a more consistent manner which allows us to remove some
redundancies.
2020-06-19 15:18:02 +02:00
Martin Kleusberg d08dcba329 parser: Add support for named CHECK, DEFAULT, and COLLATE constraints
This adds support for fully parsing named CHECK, DEFAULT, and COLLATE
colum constraints. With these changes it is possible to edit table using
these named constraints without losing any information. It is still not
possible to edit these names via the UI though.
2020-06-19 14:48:06 +02:00
Martin Kleusberg 1559fb3aab parser: Extended support for NOT NULL and UNIQUE column constraints
This adds support for conflict actions in NOT NULL and UNIQUE column
constraints. It also supports named NOT NULL and UNIQUE column
constraints. With this it is now possible to edit tables which make use
of these constraints without losing any information. Adding constraints
like this via the UI is still not supported though.

Once more constraints are handled like this, the code can be probably
simplified a lot.
2020-06-19 13:13:23 +02:00
Martin Kleusberg 60f121434c Fix empty filters in project files
Fix loading of project files with empty filter values. If an empty
filter value was saved in a project file, it did not show up in the UI
but was partially added to the query anyway. This lead to an invalid
query with no results.

Also fix a possible loophole which at least in theory could lead to an
empty filter value being stored in the project file.

See issue #2288.
2020-06-19 10:35:46 +02:00
Justin Clift f7e593a8a4 Updated bug report template for 3.12.0 release 2020-06-18 15:30:19 +10:00
Justin Clift 4bd2b916da Update currentrelease file for 3.12.0 2020-06-17 16:36:12 +10:00
Martin Kleusberg 7c6ef2ae51 dbhub: Add text to upload button
Add some text ("Upload") to the push database button in the Remote dock
to make its function more obvious.
2020-06-13 11:58:30 +02:00
Martin Kleusberg 5cdda28608 dbhub: Log in by only selecting an identity, no need to press a button
This removes the login button from the dbhub dock. Instead of selecting
an identity and then clicking the login button, you are now logged in by
just selecting an identity.
2020-06-13 11:37:30 +02:00
Justin Clift fa3a0f5756 Updated French translation 2020-06-11 15:39:52 +10:00
Martin Kleusberg 834e6508bf Refactor TableBrowser class to make it easier to read and maintain
While easier maintainability is the main point of this commit it has two
more side effects: It fixes a big which leads to the filter row being
cleared when toggling the rowid visibility and it should improve the
performance a bit by avoiding double work.
2020-06-10 21:02:26 +02:00
Martin Kleusberg 535243ad67 Remove unused code 2020-06-10 15:46:46 +02:00
Martin Kleusberg ff37c90155 Add iif SQL function to the list of known functions in Execute SQL tab
This adds the iif function to the list of known functions for which we
offer tooltips in the Execute SQL tab. It was introduced in SQLite
3.32.0.
2020-06-10 15:28:27 +02:00
Martin Kleusberg facbcec793 Replace more Qt containers by STL containers and fix a ton of warnings 2020-06-10 15:05:22 +02:00
Martin Kleusberg 5748e14f9e Simplify code a bit
This removes some unnecessary complexity which was left over from an
experiment which did not quite work out as expected.
2020-06-10 14:53:13 +02:00
Bernardo Sulzbach 1e88dd8d59 Updates the Brazilian Portuguese files for 3.12.0 2020-06-09 23:37:36 +02:00
mgrojo 2a6acbfaae update German translation for v3.12.x
# Conflicts:
#	src/translations/sqlb_de.ts
2020-06-09 21:39:21 +02:00
Martin Kleusberg f559026537 Rename 'Open tab' to 'New tab' in the Execute SQL area
See issue #2276.
2020-06-09 20:38:24 +02:00
Martin Kleusberg 23b1021d34 Scale large images in ImageViewer to fit the viewport by default
See issue #2029.
2020-06-08 20:28:46 +02:00
Martin Kleusberg d653bf9f9b Replace some more Qt containers by their STL counterparts 2020-06-08 16:06:56 +02:00
Martin Kleusberg 2f28a3ef5c Drop support for loading the old project file format
This drops support for loading project files with binary data as created
until version 3.10.
2020-06-08 15:42:23 +02:00
Justin Clift 044e4842e8 Merge pull request #2275 from scottfurry/convert
Update to Windows Icon Generation script
2020-06-07 16:21:41 +10:00
Scott Furry 90698e5dc3 Update to Windows Icon Generation script
Update script `src/tools/create_windows_icon.sh`.
Script uses Imagemagick `convert` command and requires attention to ordering of arguments.

Script update for use w/ Bash 5
2020-06-07 00:17:51 -06:00
Martin Kleusberg fa04d72f20 Fix possible crash when loading project files
This fixes a possible crash when loading project files which occurs with
some versions of Qt when trying to set the column widths in the Browse
Data tab.

Thanks to @hertzhaft for spotting and fixing this.

See issue #2232.
2020-06-06 16:45:12 +02:00
Justin Clift ba1c2a10ff Update Windows icon creation script at Scott suggestion :)
As per https://github.com/sqlitebrowser/sqlitebrowser/pull/2270
2020-06-06 13:33:51 +10:00
Justin Clift 454f182d28 Merge pull request #2270 from scottfurry/icon_cleanup
Application icon cleanup
2020-06-06 13:30:19 +10:00
Scott Furry 1ddb403593 Application icon cleanup
Ensure images used for application icon are a "best quality" image
with consistent square size. A sharp, square image is vital for downstream
usage/installation.

File `images/logo.svg` was taken as canonical source. File was edited in
inkscape. It's document properties were cleaned up(incl. image metadata).
Document viewport was made to be a large size and square(256px^2).
Image itself was resized to ensure an 8px margin.

File `images/logo.png` was created from svg (inkscape `export to png`
command). Image was generated with high compression as well as ensuring
an alpha layer and square sizing.

File `src/icons/sqlitebrowser.png` was copied from `images/logo.png`.
2020-06-05 04:30:19 -06:00
Martin Kleusberg 81bddb45d5 Do not show fields twice when parsing a table was incomplete
When the CREATE TABLE statement of a table could not be parsed
completely we asked SQLite for more information on this table and added
that to the table representation. This however made all fields appear
twice. With this commit we only ask SQLite for information on the table
when our parser did not yield any information at all to avoid this
problem.

See issue #2269.
2020-06-05 11:40:35 +02:00
Martin Kleusberg f81da0d29c Remove "NULL" in margin of editor in Edit dialog for empty cells
When clicking on a cell with a NULL value while, the Edit dialog
switches into text mode and shows an empty text with "NULL" written in
the line number margin. When then changing to an empty string cell, the
text in the editor did not change (it is still empty after all). This
prevented an action from triggering which meant that the "NULL" text in
the line number marging was not removed.

See issue #2204.
2020-06-03 17:04:46 +02:00
Martin Kleusberg d3c69ad291 Add zooming to image viewer in the Edit Dialog
This adds some basic zooming functionality to the image viewer used in
the Edit Dialog.

See issue #2029.
2020-06-03 15:03:15 +02:00
Martin Kleusberg d0978ef462 Move image viewer from EditDialog into a separate class
This does not change any look or functionality but is only a preparation
towards adding more features to the image viewer.

See issue #2029.
2020-06-03 11:09:31 +02:00
Martin Kleusberg 61544e8905 Fix some warnings 2020-06-03 10:20:56 +02:00
mgrojo 896b0daa86 New setting for having close button on tabs (default) or not
Corner widget has been removed, since it has been agreed that it is too
stray from the tabs.

See issues #1968 and #2155
2020-06-03 00:02:39 +02:00
horst-p-w-neubauer 9b29c2f7ee fix ui mistake (4x XyMargin)
done: fix ui mistake (4x XyMargin)
2020-06-02 21:36:08 +02:00
horst-p-w-neubauer 276c0a0225 fix ui mistake (reset currenIndex to 0)
fix ui mistake (reset currenIndex to 0)
2020-06-02 21:36:08 +02:00
horst-p-w-neubauer c4b43816a7 rearrange preferences database
rearrange preferences database:
* skip advanced button
* allways show editDatabaseDefaultSqlText and its label
* use complete southern dialogspace for sql edit widget
2020-06-02 21:36:08 +02:00
Justin Clift 98b0c767d5 Use port 443 for DBHub.io traffic, to be more enterprise firewall friendly 2020-05-30 23:54:49 +10:00
mgrojo 5e5c481fd4 Removed all translations of key shortcuts.
- Removed translation of Function keys for all languages
- Removed also remapped shortcuts for Italian

See issue #2178 and discussion in PR #2235.
2020-05-20 00:24:31 +02:00
horst-p-w-neubauer 308e6ec7d1 Update sqlb_de.ts
one missing 'Ctrl' to 'Strg' translation in explaining text
2020-05-20 00:24:31 +02:00
mgrojo d6ab17311a Avoid unchanged translation of keyboard shortcuts to work around problems
There are some problems with some translations where the keyboard shortcut
does not work when translated. To prevent those problems, a general
reset of all the translations which are supposed to not change the actual
key combination has been made.

Only some shortcuts in Italian are clearly changed by the translation and
those have been preserved.

See issue #2178
as is.
2020-05-20 00:24:31 +02:00
Martin Kleusberg b16017e11c Update schema after attaching/detaching a database in an Execute SQL tab
We did not detect ATTACH and DETACH statements when checking for
executed statements which require reloading of the database schemata.

See issue #2255.
2020-05-19 12:08:08 +02:00
Justin Clift 6115548a61 Update SQLCipher to new v4.4.0 release for our Windows builds 2020-05-16 09:09:48 +10:00
Martin Kleusberg 5de9a97250 Replace misleading text
Replace "Filter in all columns" by "Filter in any column".

See issue #2233.
2020-05-13 13:07:31 +02:00
Martin Kleusberg 11a4c6c880 Fix whitespace 2020-05-06 15:52:40 +02:00