Nick Tobey
743eb87fce
Respond to PR comments.
2025-02-24 19:32:08 -08:00
Nick Tobey
4c3748c4e4
Apply suggestions from code review
...
Co-authored-by: Jason Fulghum <jason@dolthub.com >
2025-02-24 19:31:51 -08:00
Nick Tobey
3c2827704f
Add comment to bats test.
2025-02-21 12:49:36 -08:00
Nick Tobey
d5c0f5abb2
Fix typo in env var name.
2025-02-21 12:47:44 -08:00
Nick Tobey
d3aaf30140
Set the collation when replacing a column in a schema.
2025-02-20 11:21:23 -08:00
Nick Tobey
997bfefa91
Avoid skipping the table check for spatial types: it may be needed even if the table values don't change.
2025-02-19 20:32:13 -08:00
nicktobey
021a883e4d
[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
2025-02-20 03:29:39 +00:00
Nick Tobey
10e558dbbc
Add --DOLT_GC_SAFEPOINT_CONTROLLER_CHOICE environment variable and tests.
2025-02-19 19:20:37 -08:00
nicktobey
3126479a16
[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
2025-02-20 01:07:29 +00:00
Nick Tobey
97ddfde68f
Update type compatibility test.
2025-02-19 16:57:37 -08:00
Nick Tobey
51969e81ba
Use TypeCompatibilityChecker to determine whether to rewrite a table during a schema change.
2025-02-17 13:48:34 -08:00
Nick Tobey
e6a8ab1e3f
Don't rewrite table when making a varchar or varbinary column have a larger length.
2025-02-17 11:10:33 -08:00
Nick Tobey
1772eac120
Don't rewrite enum columns when not necessary.
2025-02-16 14:40:09 -08:00
Aaron Son
4c93a25fbc
Merge pull request #8863 from dolthub/reltuk-1e0e5e8f
...
[auto-bump] [no-release-notes] dependency by reltuk
2025-02-14 13:31:51 -08:00
reltuk
c9133db51f
[ga-bump-dep] Bump dependency in Dolt by reltuk
2025-02-14 20:43:09 +00:00
Neil Macneale IV
eb91821ce1
Merge pull request #8857 from dolthub/macneale4/archive-clone-fetch
...
[no-release-notes] archive clone/fetch
2025-02-13 17:55:34 -08:00
Aaron Son
d4a62c13b7
Merge pull request #8848 from dolthub/aaron/async-push-hook-session-lifecycle
...
[no-release-notes] go: sqle: Change how we run background threads for replication hooks. Add session lifecycle callbacks for replication hooks.
2025-02-13 17:14:11 -08:00
Aaron Son
f662a63b1e
Merge pull request #8858 from dolthub/aaron/gc-clear-caches
...
[no-release-notes] go: sqle: dolt_gc: Purge read caches associated with the DoltDB as we begin GC.
2025-02-13 17:12:50 -08:00
Neil Macneale IV
2cab73a144
Archive test updates to account for default dictionaries
2025-02-13 16:47:01 -08:00
Aaron Son
cd8372b9c8
go: prolly/tree: node_store.go: Doc comment on PurgeCaches.
2025-02-13 16:38:32 -08:00
Aaron Son
ced4653888
go: store: nbs: Improve goroutine cleanup on gc_copier, some robustness improvements on KillConnection safepoint controller.
2025-02-13 16:36:43 -08:00
Neil Macneale IV
b086492018
Account for empty chunks in archive.getManyCompressed
2025-02-13 16:05:48 -08:00
Neil Macneale IV
77a4e59fc2
More PR Feedback
2025-02-13 15:44:57 -08:00
Neil Macneale IV
2434b63eae
PR Feedback
2025-02-13 15:39:06 -08:00
Neil Macneale IV
63e29a790d
rollback the change to the getMany interface
2025-02-13 15:24:08 -08:00
Aaron Son
d459962770
Merge pull request #8851 from dolthub/aaron/valuestore-gc-states-unit-tests
...
[no-release-notes] go/store/types: value_store: Add some unit tests for gc states and gcAddChunk behavior.
2025-02-13 14:48:20 -08:00
Aaron Son
ea5615dae2
go: store/types: value_store_test.go: PR feedback, some comments.
2025-02-13 14:47:39 -08:00
Aaron Son
64cef607e3
Merge pull request #8854 from dolthub/aaron/statspro-session-lifecycle
...
[no-release-notes] go: statspro: Add session lifecycle callbacks to integrate with session-aware GC safepoint controller.
2025-02-13 14:40:07 -08:00
Neil Macneale IV
ecac26bf2b
Remove the FullCompressedChunkLen function from ToChunker interface
2025-02-13 12:23:47 -08:00
Neil Macneale IV
c76ab7e7d9
more cleanup
2025-02-13 10:55:01 -08:00
reltuk
caa1e47e8a
[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
2025-02-13 18:32:20 +00:00
Aaron Son
c8353bb053
go: Fix some tests for new ValueStore cache purging behavior where we rely on a safepoint controller to do it.
2025-02-13 10:24:23 -08:00
Aaron Son
78d451b883
go: remotestorage: chunk_fetcher: Ranges carry the Dict{Offset,Len}, instead of a GetDict callback.
2025-02-13 09:53:42 -08:00
Aaron Son
52fab61a3d
go: remotestorage: Some cleanups to ChunkFetcher.
2025-02-13 09:32:15 -08:00
Aaron Son
4a3d7f8177
go: remotestorage: Rework how dictionary fetching and dictionary cache is populated.
2025-02-12 18:34:20 -08:00
Zach Musgrave
21547c4027
Merge pull request #8847 from dolthub/zachmu/ignore
...
Added an extension point for doltgres to lookup values in the dolt_ignore table
2025-02-12 16:05:30 -08:00
macneale4
dbef286672
[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
2025-02-12 23:09:24 +00:00
Neil Macneale IV
72e7029580
More ToChunker refactor
2025-02-12 14:55:37 -08:00
reltuk
6561f452ac
[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
2025-02-12 22:09:31 +00:00
Aaron Son
18d7ceb847
[no-release-notes] go: sqle: dolt_gc: Purge read caches associated with the DoltDB as we begin GC.
...
The right place to do this is in the safepoint controller, at BeginGC. We need
to do it after keeperFunc is installed on the NomsBlockStore, so that all read
dependencies are taken. We also need to do it before we register all sessions
whose cached state we need to visit.
2025-02-12 14:01:23 -08:00
macneale4
c3440f0d22
[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
2025-02-12 13:49:45 -08:00
Neil Macneale IV
57c6a21cb2
Small refactor and clean up
2025-02-12 13:49:45 -08:00
Neil Macneale IV
f8330ff852
Make metadata code aware of newgen archives
2025-02-12 13:47:43 -08:00
Neil Macneale IV
1f498f832c
Use better dictionary cache
2025-02-12 13:47:43 -08:00
Neil Macneale IV
6c270b1d2c
First steel thread for archive fetch.
2025-02-12 13:47:43 -08:00
macneale4
66f1b9f73c
[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
2025-02-12 13:47:43 -08:00
Neil Macneale IV
8f933ce76a
Clone tests passing again
2025-02-12 13:47:43 -08:00
Neil Macneale IV
564c1f1820
Checkpoint: url generation fixed, and no longer blocking incorrectly
2025-02-12 13:47:43 -08:00
Neil Macneale IV
5fbe0d1d87
Munge the location path in GetChunkLocationsWithPaths
2025-02-12 13:47:43 -08:00
Neil Macneale IV
0ae4d51b86
Revert tableSpec field changes
2025-02-12 13:47:43 -08:00
